docs: recommend making an issue before making an enchancement#2391
Merged
aucampia merged 1 commit intoRDFLib:mainfrom May 19, 2023
Merged
Conversation
aucampia
force-pushed
the
aucampia/20230519T1058-enhancement_guidance
branch
from
4bbb9c3 to
b68c41e
Compare
aucampia
added
review wanted
Suggest that contributors first make an issue to get in principle agreement for pull requests before making the pull request. Enhancements can be controversial, and we may reject the enhancement sometimes even if the code is good, as it may just not be deemed important enough to increase the maintenance burden of RDFLib. Other changes: - Updated the checklist in the pull request template to be more accurate to current practice. - Improved grammar and writing in the pull request template, contribution guide and developers guide.
aucampia
force-pushed
the
aucampia/20230519T1058-enhancement_guidance
branch
from
b68c41e to
3f3b638
Compare
ghost
approved these changes
May 19, 2023
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
well worth making it clear and explicit 👍
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Suggest that contributors first make an issue to get in principle agreement for pull requests before making the pull request.
Enhanements can be controvarsial and we may reject the enhancement sometimes even if the code is good, as it may just not be deemed important enough to increase the maintenance burder of RDFLib.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.